The NES Advantage is the best controller ever as far as I'm concerned.
There's also this:
Blaze Twin Shock Arcade Joysticks
I bought this for my playstation a while ago (though mine is the limited edition black version with red buttons). The thing is friggin huge and it's
perfect for anybody that enjoys standard arcade controls. I love this thing. :o